Shibby v107,v108 - BUG with dnsmasq v2.66test16


But the current functionality is not being completely re-created. In the current GUI, if 'use internal DNS' is disabled then instead of the local (to that dhcp range) interface being passed as the dns server option in DHCP, then either any statically defined DNS servers are passed as option 6 (which your changes do cope with) *OR* the currently supplied DNS servers from the ISP (presumably provided by dhcpc) are. If there are no currently defined dns servers ('cos the WAN link is still being brought up say) then the lease time is reduced to 2 minutes (presumably in the hope that the WAN link will be up soon) and the DNS servers are then passed on.

Exactly how this code is 'kicked' such that it knows the WAN is up is something I definitely do not understand. And it's something that shouldn't be changed without full understanding of the existing code behaviour which I and you do not have.

Also, your BR3 example is something by your own statement that cannot realistically be configured. I have to agree with Simon here in that the program *is* called *DNS*masq not dhcpmasq or dhcpdnstftpmultimegaloadsofoptionsserver (you've read the man page like me, I think it has enough bl**dy options already!)

Until all the implications are understood, I still subscribe to a per interface flag that in essence says 'use existing behaviour' or 'don't even think about touching the config file for this interface' - that will not break anything and is much easier to implement. Yes it's not as sexy but it'll work.

If the plan is to really go for it on this, then there's at least one other parameter that should be configurable per interface and that's the WINS server - 3 states 'disabled', 'statically defined', 'use internal SAMBA server' (which will change according to which interface we're talking about) And then there's IPv6 which I really don't want to get into! :)

The VLAN code is/was an add on - Toastman still considers it experimental - I think this is probably just one example of why it should still be considered so. Yes it can and should be fixed.....by someone who understands and can write code and also understands networking.
 
In the meantime I've gone back to the original problem and think there's a suitable short-term easy code fix. If the 'no-dhcp-interface' line is supressed then there's no harm done because we also do not define a dhcp range to serve anyway. So despite the fact we've no longer specifically excluded an interface from listening to dhcp requests, since we've nothing defined to serve on it anyway, things should be safe.
 
After giving it consideration. I agree with you. The most basic form of what is needed is simply, clean up the .conf file a bit so that conflicts don't occur and make it possible to specify what you really need in the custom config by removing all traces of .conf entries for a specific interface.

The proposed solution was based what I consider to be the ideal solution to the problem; however, it is ambitious as it necessitates modification of the GUI and base binaries. I do want to point out that the Default DNS setting was simply to specify that it should behave as it does now. Not to change any code, only to make the results of that code visible by populating the table with the results. If Default DNS was enabled, then it would be the exact value it is now. The only change would be if you over-ride that and specified your own DNS, and if that value was 0.0.0.0 in conjunction with a disabled DHCP then remove all .conf entries. That's it,I thought that was pretty reasonable and would provide a GUI that was flexible enough to handle even more later down the road, but I can see how it may add more time to get results than what you propose. Anyway, let's proceed with the "shortest route to victory" approach. We have both spent enough time on this already ;)
 
Kevin - I see a fix for the dupe option problem in your tree. Assume you had something to do with getting this fixed. Thanks!
 
Kevin - I see a fix for the dupe option problem in your tree. Assume you had something to do with getting this fixed. Thanks!

Yes, but though it compiles I've not yet actually had a chance to test it. A firmware file is sat on my laptop waiting for me to return home & upload.

But you may have have noticed one of the other commits which prevents 'no-dhcp-interface' being written out anyway, so in theory the problem you found has been 'fixed' twice :)
 
[quote="Kevin Darbyshire-Bryant, post: 225630, member: 45865]But you may have have noticed one of the other commits which prevents 'no-dhcp-interface' being written out anyway, so in theory the problem you found has been 'fixed' twice :)[/quote]

The 'no-dhcp-interface' issue was RDHLLC's (and yes I saw both commits), but the general issue of manual entries overriding generated entries was just as important IMO. I do have some units where that is needed.
 

Back
Top