[Fork] Tomato-ARM by @kille72

Discussion in 'Tomato Firmware' started by kille72, Mar 24, 2017.

  1. JonnY90

    JonnY90 Networkin' Nut Member

    @kille72

    thanks for your advice to clear the cache. It worked!
     
    pomidor1 likes this.
  2. sesnut

    sesnut Network Newbie Member

    transmission doesnt work properly on 2017.3 on my ac68
    none of the torrents can connect to the tracker
    cleared the nvram too, no dice
    it works fine on 2017.2
     
  3. kille72

    kille72 LI Guru Member

    No problems here on 2017.3...

    torrent.PNG
     
  4. WildFireSG

    WildFireSG Addicted to LI Member

    Hi @kille72

    Any thoughts on supporting the new ASUS RT-AC86U?
     
  5. kille72

    kille72 LI Guru Member

    No plans... We will try to get the AC68U C1/E1 to work first, waiting for source code from Shibby.
     
    Elfew and pomidor1 like this.
  6. sesnut

    sesnut Network Newbie Member

    it cant resolve hosts for some reason, it still connect to peers thru dht
    if i try and ping a domain name it says bad address

    it works fine if i revert to 2017.2
     
    Last edited: Jan 15, 2018
  7. pomidor1

    pomidor1 Networkin' Nut Member

    How long do you think we will wait? :p;)
     
  8. eangulus

    eangulus Network Guru Member

    I have had both an E3000 and N66 crap out due to heat issues. In both cases I did not monitor the temperature routinely which led to premature death. In both cases 2-3 years was the lifecycle before death.

    A replacement N66 and my curent R7000 sit on a laptop cooler and maintain CPU temperatures at or below 50C. The N66 is now 3 years old and running fine (at the parents house) and the R7000 is now approaching 1.5 years with no issues.

    YMMV but 80C (175F) is probably cooking the components and when there is even a slight cooling (at night) then something is separating or flexing leading to issues.

    You may be able to extend the life by keeping it cool, but probably the unit is done for.

    The other thing you might first check is the power connector (wall-wart). If this is failing and under/over volting that could lead to problems too. But I would cool your unit too. A laptop cooler is $10 and uses <1 watt of power. Cheap insurance.[/QUOTE]Thanks for that insight. I thought of the power the other night. Sourcing a PSU to test, but I think your right about it being cooked.

    Sent from my Pixel XL using Tapatalk
     
  9. kille72

    kille72 LI Guru Member

    You can try to fix a programmer who can high-level trix at kernel level, then it will be quick....:p
     
    Last edited: Jan 16, 2018
    Elfew and The Master like this.
  10. kille72

    kille72 LI Guru Member

    We will make some changes:

    1. Update Nginx from Legacy version 1.10.3 to Mainline version 1.13.8
    2. Fixes in MultiWAN-Watchdog (in some cases, the network connection is still considered by Tomato as active)
    3. MultiWAN connection status in the GUI, whether it works whether it is fail-over (standby) or fail-over (active):
    wan: Active
    wan2: Failover (standby)

    If everything goes well, I will compile test versions in a few days :)

    /Shibby/Pedro/Kille72
     
    Last edited: Jan 18, 2018
  11. The Master

    The Master Network Guru Member

     
  12. Elfew

    Elfew Network Guru Member

    Great news :)
     
    kille72 likes this.
  13. AndreDVJ

    AndreDVJ LI Guru Member

    I don't think anybody recently left Tomato running for a long time recently. I've been quiet not doing anything since December 5th, and haven't rebooted my router ever since.

    upload_2018-1-18_20-19-33.png
     
  14. Wizardknight

    Wizardknight Reformed Router Member

    Clearly Photoshoped. ;)
     
  15. kille72

    kille72 LI Guru Member

    Good news! I left my AC56U running for 1 year with the Tomato v130 once :)
    tomato.png
     
    Darkbing and Elfew like this.
  16. Sean B.

    Sean B. LI Guru Member

  17. joksi

    joksi Serious Server Member

  18. moonpie2000

    moonpie2000 Network Newbie Member

    Not sure if anyone else has ask about this or if you are even aware but there has been a long time (before your fork) know issue with using the 'captive portal' when you are using VPN. In my case when using the VPN client with routing policies the captive portal does not work when using on my guest WiFi LAN1(BR1). I was hoping that maybe you could review the code and see if you could fix it. Thanks for any help you can provide.
     
  19. kille72

    kille72 LI Guru Member

    Check the results on version 2017.2 with the older WLAN driver. Erase NVRAM after the upgrade.
     
  20. kille72

    kille72 LI Guru Member

    I do not think it's possible to do that. Can anyone correct me if it's wrong?
     
  21. joksi

    joksi Serious Server Member

    HI Kille72,

    I just tried it and there is no difference, still 10-15mbps downstream and 80-90mbps upstream with factory defaults. :(
     
  22. kille72

    kille72 LI Guru Member

    Open new thread and ask others with the same router what they have for speeds with Tomato. I am sorry but I do not really know how to help you...
     
  23. The Master

    The Master Network Guru Member

    Hi Kille72,

    i dont know if i ask you this but is it possible to add "Yearly" to "WAN Bandwidth" or make the Monthly List LONGER 2-xx Years.

    Thanks for your hard work.
     
  24. The Master

    The Master Network Guru Member

    Any news about the Test Version?
     
  25. Solace50

    Solace50 Connected Client Member

    @kille72
    1.28.0000 -2017.3b13-kille72- K26ARM USB AIO-64K

    Will not successfully list directory of FTP when accessing from WAN connections and the port is specified aside from 21, the custom port was also configured in port forwarding for the routers IP address/port.
     
    kille72 likes this.
  26. Wizardknight

    Wizardknight Reformed Router Member

    I am on 1.28.0000 -2017.3, and I can confirm that if I change the FTP server port to anything other than 21 using the GUI it will not work properly over WAN also.
     
    kille72 likes this.
  27. kille72

    kille72 LI Guru Member

    It may have to wait, @pedro311 is working on various issues with ARM7, now we have a bug with FTP as well.
     
    Elfew, Wizardknight and The Master like this.
  28. Solace50

    Solace50 Connected Client Member

    Id also like to mentioned the 5ghz is unstable on a ea6900 and dropping sometimes for the latest build.
     
  29. rs232

    rs232 Network Guru Member

    Have you cleared the NVRAM while upgrading the release(s)? If not you might have a solution to this issue.
     
    kille72 likes this.
  30. The Master

    The Master Network Guru Member

    Thanks for the Info :)
     
    kille72 likes this.
  31. kille72

    kille72 LI Guru Member

    I'm looking for one or more testers who can nginx + PHP to test the latest versions in Tomato.

    Code:
    # nginx -V
    nginx version: nginx/1.13.8
    built with OpenSSL 1.0.2n  7 Dec 2017
    TLS SNI support enabled
    Code:
    # php-cgi -v
    PHP 7.2.2 (cgi-fcgi) (built: Feb  4 2018 15:43:48)
    Copyright (c) 1997-2018 The PHP Group
    Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
     
    Last edited: Feb 6, 2018
    pedro311 and The Master like this.
  32. eibgrad

    eibgrad Network Guru Member

    deleted.
     
  33. Edrikk

    Edrikk Network Guru Member

    I'm always of the mind to publicly post the betas. It gives people the opportunity to test, and also keeps people from constantly asking "when's the next build."

    Kills two birds with one stone.. ;)
     
    M_ars and kille72 like this.
  34. pomidor1

    pomidor1 Networkin' Nut Member

  35. kille72

    kille72 LI Guru Member

    Last edited: Feb 6, 2018
    Elfew, The Master and pomidor1 like this.
  36. Hermes Romero

    Hermes Romero Connected Client Member

    Hi guys

    I have a R7000 with latest AIO version. I configured the 5Ghz to 80 Mhz but in the overview it show it as 40 MHz. I tried changing the country with no luck. Any clue?

    BTW: thanks for bringing Tomato back to life.

    Update: it only happens when "channel" is configured as "auto".

    Thanks
     
    Last edited: Feb 11, 2018
    pomidor1 likes this.
  37. Elfew

    Elfew Network Guru Member

  38. kille72

    kille72 LI Guru Member

    The Master and pomidor1 like this.
  39. Elfew

    Elfew Network Guru Member

    SDK7 - so which routers?
     
  40. kille72

    kille72 LI Guru Member

    AC3200 and R8000, good start anyway!
     
    pomidor1 and Elfew like this.
  41. Elfew

    Elfew Network Guru Member

    Yes, the first small step :)

    What about supporting newer revisions of some Asus routers? I mean B/C rev. which use newer SDK. Is there any progress from @shibby20?
     
    pomidor1 and kille72 like this.
  42. kille72

    kille72 LI Guru Member

    No yet :(

    And now we are struggling with PHP 7.2.x to make it work correctly with MySQL also...
     
    Last edited: Feb 11, 2018
  43. Elfew

    Elfew Network Guru Member

    Fingers crossed! So @shibby20 is back?
     
    The Master and kille72 like this.
  44. eangulus

    eangulus Network Guru Member

  45. kille72

    kille72 LI Guru Member

    Last edited: Feb 12, 2018
  46. Elfew

    Elfew Network Guru Member

    Joe A and (deleted member) like this.
  47. Onee-chan

    Onee-chan Network Newbie Member

    Your firmware damages/bricked my router RT-AC68P (I'm going to report to the ONU), the lights do not turn on, CMD does not respond when I ping 192.168.1.1 only this appears:

    It's a joke works great, I'm using the Version 2017.3

    [​IMG]
    Thanks!
     
    maurer and Testing like this.
  48. Edrikk

    Edrikk Network Guru Member

    That has to be the least funny “joke” I’ve ever heard.
     
  49. Testing

    Testing Connected Client Member

    Install [Fork] Tomato-ARM by @kille72 in an ASUS RT-AC68P Router
    01. First I did a Factory reset in the ASUS RT-AC68P Router (Official Firmware v3.0.0.4.384.20308)
    02. Download and Install Firmware Restoration: (I use v2.0.0.0)
    03. Download and unzip on the desktop the Tomato Firmware:
    04. Add a Static IP in the Computer:
    • IP address: 192.168.1.5
    • Subnet mask: 255.255.255.0
    • Default gateway: 192.168.1.1
    05. Turn off the router.
    06. Connect the Router to the Computer via Ethernet Cable.
    07. Open command prompt (CMD) and write ping -t 192.168.1.1 and press Enter.
    08. With a pencil press the Reset button without releasing it and Turn on the router about 10 seconds, then release the Reset button.
    09. Open the program Firmware Restoration, click on Browse and found the Tomato Firmware.
    10. After click on Upload.
    11. Wait 5 minutes to assure flash integrity.
    12. If you can not log into web interface (192.168.1.1), Then you need reset NVRAM, you will have to turn off the router, press the WPS button without releasing it, then turn on the router. Wait about 20 seconds, then release the WPS button.
    13. Remove the Static IP in the Computer.
    14. To be sure, Log into web interface (192.168.1.1) go to Administration -> Configuration in the section Restore Default Configuration select Erase all data in NVRAM memory (thorough) click on ok.
    15. The last step and the most important Configure QoS like this:


    Return to the Official Firmware from [Fork] Tomato-ARM by @kille72
    01. Log into web interface (192.168.1.1) go to Administration -> Configuration in the section Restore Default Configuration select Erase all data in NVRAM memory (thorough) click on ok.
    02. Download and Install Firmware Restoration: (I use v2.0.0.0)
    03. Download and unzip on the desktop the Official Firmware:
    04. Add a Static IP in the Computer:
    • IP address: 192.168.1.5
    • Subnet mask: 255.255.255.0
    • Default gateway: 192.168.1.1
    05. Turn off the router.
    06. Connect the Router to the Computer via Ethernet Cable.
    07. Open command prompt (CMD) and write ping -t 192.168.1.1 and press Enter.
    08. With a pencil press the Reset button without releasing it and Turn on the router about 10 seconds, then release the Reset button.
    09. Open the program Firmware Restoration, click on Browse and found the Official Firmware.
    10. After click on Upload.
    11. Wait 5 minutes to assure flash integrity.
    12. If you can not log into web interface (192.168.1.1), Then you need reset NVRAM, you will have to turn off the router, press the WPS button without releasing it, then turn on the router. Wait about 20 seconds, then release the WPS button.
    13. Remove the Static IP in the Computer.
    14. To be sure, Log into web interface (192.168.1.1) and make Factory reset on the Router ASUS RT-AC68P


    Thanks to @Sean B. for Show Me Da Way!
     
    Last edited: Feb 18, 2018
    AndreDVJ likes this.
  50. lubmar

    lubmar Connected Client Member

    I am not getting "full speed" after changing internet speed (from 5/1 to 30/5mbps) ...
    I have a netgear r6300v2 on the latest firm. (i did install it with nvram cleanup - all setting typing in etc.)

    before the internet change I could get all the 5/1 speed on wire and wifi both 2.4 & 5
    after the change I get the 30/5 on wire almost 30/5 on 5 wifi , but only 6/5 on 2.4 .
    I did rebooted modem and router but nothing helped ...
    any advice ?
    thanks
     
  51. eangulus

    eangulus Network Guru Member

    I think that if someone needs as detailed instructions as these, then maybe they shouldn't be screwing around with their router.

    Sent from my Pixel XL using Tapatalk
     
  52. txnative

    txnative Networkin' Nut Member

     
  53. txnative

    txnative Networkin' Nut Member

    :rolleyes: Not everyone thinks in this way, I feel that having detailed information whether it being in here or anywhere it is a must, from the novice to advanced it helps.
     
  54. AndreDVJ

    AndreDVJ LI Guru Member

    I appreciate, because I'm not really good in teaching novices. Even I still struggle with QoS, because I don't have the patience to test extensively until I figure out something that works for me.
     
  55. Sysop Grace

    Sysop Grace Network Newbie Member

    Can I build the current source on a computer and then use it on a R7000 or does it need to be built on the target platform itself?
     
  56. Sean B.

    Sean B. LI Guru Member

    The tool chain is provided to cross compile ARM under a Linux host. The host system is required to have several specific package versions installed, and a symlink created for the tool chain. I believe specifics are available in one of the sources readme's. If not, run a search on this forum for building the firmware, many threads contain the info.
     
  57. lubmar

    lubmar Connected Client Member

    it is the Latest version 2017.3 from this tread , did not change any settings (except wpa2 security/password) , not using QOS or limiters etc.
    the router is the v2 version with the 3.0 usb , I will try to flash it again and see if it will help ...
     
  58. Wizardknight

    Wizardknight Reformed Router Member

    It has been reported by some people that the 2.4Ghz speeds are reduced with this firmware due to a driver change. You might be better off trying Shibby's last release. I am seeing poor performance on my 6300v2 @ 2.4Ghz, but I don't care a lot as the only device I am using it with is a tablet.
     
  59. txnative

    txnative Networkin' Nut Member

    I agree also that 2.4 has throughput issues and if you are able to do as Wizardknight post suggests to use one of shibby last releases and try to use some tweaks that may help as well or maybe use kongac build but research first before installing.
     
  60. kille72

    kille72 LI Guru Member

    We have an old version of MySQL in Tomato ARM-AIO, 5.1.73 (2013-12-03). It would be great to upgrade to at least version 5.5.59 (2018-01-15) so we have patched nginx + PHP + MySQL. "make" has been replaced with "cmake" in MySQL 5.5, I'm not a programmer and I don't succeed to compile newer MySQL with Tomato toolchain. Can any programmer help me with this please?
     
    Last edited: Feb 15, 2018
    The Master and Hermes Romero like this.
  61. lubmar

    lubmar Connected Client Member

    how poor ? what speed you getting ?
    over the weekend I will try to flash it to old ver. test it and then back to the newest and see if anything will change ...
    thanks
     
  62. Sean B.

    Sean B. LI Guru Member

    I would suggest building the newer MySQL on your opt partition under the firmware environment itself of a router. This eliminates all the variables of integration with Tomato code and cross compiling system. You can determine just how many things will actually need to be added/updated to get a working installation of the newer version, rather than fighting one thing to find there's 14 more behind it the hard way. Cmake is available via optware-ng: http://ipkg.nslu2-linux.org/optware-ng/buildroot-armeabi-ng/cmake_3.10.2-1_arm.ipk
     
  63. joksi

    joksi Serious Server Member

    I have a Netgear R6250 andaunfortunately have to accept this it seems. I have tried both Killes releases and Shibby, and both have the same problwms with 2.4ghz downstream specifically.
     
  64. RMerlin

    RMerlin Network Guru Member

    Upgrading MySQL from 5.1.x to something newer can potentially break existing databases - thread carefully there...
     
    Sean B. and kille72 like this.
  65. The Master

    The Master Network Guru Member

    With AndreDVJ Build of Tomoato shibby/kille72 Build i could not connect with me LTE Stick any more.(tomato-R7000-AT-ARM-3.5-140-AIO-64K_FEB13_f7720016.trx AndreDVJ 2018-02-13)

    Got This Error:
    Code:
    daemon.warn miniupnpd[2609]: interface index not matching 0 != 12 Feb 16 15:59:39 daemon.warn miniupnpd[2609]: interface index not matching 0 != 12 Feb 16 15:59:39  daemon.warn miniupnpd[2609]: interface index not matching 0 != 12 Feb 16 15:59:44 daemon.warn miniupnpd[2609]: interface index not matching 0 != 12 
     
  66. pomidor1

    pomidor1 Networkin' Nut Member

  67. joew333

    joew333 LI Guru Member

    I have also experienced the same error:
    daemon.warn miniupnpd[2609]: interface index not matching 0 != 12 This happens on both
    tomato-R7000-AT-ARM-3.5-140-AIO-64K_FEB13_f7720016.trx and tomato-R7000-ARM-2018.1.025-beta-kille72-AIO-64K.trx
     
    kille72 likes this.
  68. kille72

    kille72 LI Guru Member

    Yes, bug in miniupnpd-2.0.20171212 = log flood. I will update miniupnpd in the next version to miniupnpd-2.0.20180203.
     
    The Master likes this.
  69. WildFireSG

    WildFireSG Addicted to LI Member

    Minor request, hopefully. Any chance on getting a checkbox to display CPU and Wireless temperatures in Fahrenheit for USA users?
     
    RogueScholar likes this.
  70. joew333

    joew333 LI Guru Member

    Thank you! Much appreciated. I am a bit OCD, so it is appreciated to take away the error.
     
  71. The Master

    The Master Network Guru Member

    Thank you.
     
    kille72 likes this.
  72. user17600

    user17600 Reformed Router Member

    Can someone comment on the AndreDVJ/advancedtomato-arm versions?

    I get that they're his own builds but are they based on kille72's versions? I see inputs from pedro, kille72 and even shibby.

    Is this a branch (like pedro's beta versions)? I'm looking to fix the 2.4g band speed issues.

    Thanks, exciting to see so much participation... even shibby!
     
  73. kille72

    kille72 LI Guru Member

    Last edited: Feb 17, 2018
    edusodanos and Bobses like this.
  74. joew333

    joew333 LI Guru Member

    I have been on 2018.1.025-beta for more than 10 hours and all the main functions I use seem to work just fine (both 2.4 and 5Ghz bands, CTF, guest networks, etc.). The base CPU load on a Netgear R7000 is 2.2 - 2.4%. Only error seen is the already reported miniupnpd-2.0.20171212 log flood repeating error message. Thank you Kille72, Pedro and Shibby & others. Looking forward to the new miniupnpd!
     
  75. Urashima Taro

    Urashima Taro New Member Member

    Hello kille72,

    Thank you for your continued efforts to keep Tomato alive and fairly current. Does 2018.1.025 Beta include the fix for the KRACK vulnerability? I did not find it in your change logs but I was following some of your threads in regards to integrating "John's" update into yours, correct me if I have misunderstood. Thank you.

    Respectfully,

    H. Taro
     
  76. pomidor1

    pomidor1 Networkin' Nut Member

    kille72 likes this.
  77. kille72

    kille72 LI Guru Member

    I have tested version miniupnpd-2.0.20180203 with the same result, log flood. Easiest work around is to uncheck "enable on LAN" (everything still works well, strangely enough without log flood).

    upnpd.PNG
     
  78. user17600

    user17600 Reformed Router Member

    How's the 2.4gHz wifi performance? On 2017.3 mine's about 30% of the 5gHz speed. Would be nice to have the performance back for the guest part of the network.
     
  79. Sean B.

    Sean B. LI Guru Member

    Change the coding to use an interface name for the listening_ip= value instead of an IP/netmask.
     
  80. kille72

    kille72 LI Guru Member

    Where do I change it exactly?
     
  81. Sean B.

    Sean B. LI Guru Member

    For testing you can manually change it in the config file. Re-enable "LAN" in the GUI, then edit the /etc/upnp/config file and change listening_ip= value from the IP to br0 then kill miniupnpd, then run miniupnpd -f /etc/upnp/config .
     
  82. kille72

    kille72 LI Guru Member

    Without flood:
    Code:
    ext_ifname=vlan2
    port=0
    enable_upnp=yes
    enable_natpmp=no
    secure_mode=yes
    upnp_forward_chain=upnp
    upnp_nat_chain=upnp
    upnp_nat_postrouting_chain=pupnp
    notify_interval=60
    system_uptime=yes
    friendly_name=Asus Router
    model_name=Asus RT-AC56U
    model_url=http://linksysinfo.org/index.php?forums/tomato-firmware.33/
    manufacturer_name=Tomato Firmware
    manufacturer_url=http://linksysinfo.org/index.php?forums/tomato-firmware.33/
    
    clean_ruleset_interval=600
    clean_ruleset_threshold=20
    presentation_url=
    uuid=0f39518c-aae0-498d-aeae-bb4b28a0e4fd
    
    
    listening_ip=br0
    allow 1024-65535 192.168.1.1/255.255.255.0 1024-65535
    
    deny 0-65535 0.0.0.0/0 0-65535
     
  83. Sean B.

    Sean B. LI Guru Member

    So it does work correctly without log floods using interface name?
     
  84. kille72

    kille72 LI Guru Member

    Yes.
     
  85. Sean B.

    Sean B. LI Guru Member

    Then this section:

    Code:
    char *lanip = nvram_safe_get(lanN_ipaddr);
                        char *lanmask = nvram_safe_get(lanN_netmask);
                        char *lanlisten = nvram_safe_get(upnp_lanN);
    
                        if((strcmp(lanlisten,"1")==0) && (strcmp(lanip,"")!=0) && (strcmp(lanip,"0.0.0.0")!=0)) {
                            fprintf(f,
                                "listening_ip=%s/%s\n",
                                lanip, lanmask);
    at line 1160 of /release/src-rt-6.x.4708/router/rc/services.c needs to be changed accordingly. I'll make a patch when I have time, if no one else does before then.
     
    kille72 likes this.
  86. Sean B.

    Sean B. LI Guru Member

    @kille72 , would you do me a favor so I don't have to search the code to see if the variables for lan ifnames have been changed in your builds please? run:

    Code:
    nvram show | grep lan | grep ifname
    and post output.
     
  87. kille72

    kille72 LI Guru Member

    Here you are:
    Code:
    # nvram show | grep lan | grep ifname
    size: 39969 bytes (25567 left)
    lan2_ifnames=
    lan1_ifname=
    lan3_ifnames=
    lan2_ifname=
    wan_ifnameX=vlan2
    lan_ifnames=vlan1 eth1 eth2
    wan_ifnames=vlan2
    lan3_ifname=
    lan_ifname=br0
    wan_ifname=vlan2
    lan1_ifnames=
     
  88. Sean B.

    Sean B. LI Guru Member

    Thanks. This should do it, run a build and test it out. If there's any issues leave a post and I'll continue when I'm back from my sons basketball game.

    Code:
    diff --git a/release/src-rt-6.x.4708/router/rc/services.c b/release/src-rt-6.x.4708/router/rc/services.c
    index 40c1066..27de310 100644
    --- a/release/src-rt-6.x.4708/router/rc/services.c
    +++ b/release/src-rt-6.x.4708/router/rc/services.c
    @@ -1141,8 +1141,7 @@ void start_upnp(void)
                     fappend(f, "/etc/upnp/config.custom");
                     fprintf(f, "%s\n", nvram_safe_get("upnp_custom"));
     
    -                char lanN_ipaddr[] = "lanXX_ipaddr";
    -                char lanN_netmask[] = "lanXX_netmask";
    +                char lanN_ifname[] = "lanXX_ifname";
                     char upnp_lanN[] = "upnp_lanXX";
                     char br;
     
    @@ -1153,18 +1152,16 @@ void start_upnp(void)
                         else
                             strcpy(bridge, "");
     
    -                    sprintf(lanN_ipaddr, "lan%s_ipaddr", bridge);
    -                    sprintf(lanN_netmask, "lan%s_netmask", bridge);
    +                    sprintf(lanN_ifname, "lan%s_ifname", bridge);
                         sprintf(upnp_lanN, "upnp_lan%s", bridge);
     
    -                    char *lanip = nvram_safe_get(lanN_ipaddr);
    -                    char *lanmask = nvram_safe_get(lanN_netmask);
    +                    char *lanifname = nvram_safe_get(lanN_ifname);
                         char *lanlisten = nvram_safe_get(upnp_lanN);
     
    -                    if((strcmp(lanlisten,"1")==0) && (strcmp(lanip,"")!=0) && (strcmp(lanip,"0.0.0.0")!=0)) {
    +                    if((strcmp(lanlisten,"1")==0) && (strcmp(lanifname,"")!=0)) {
                             fprintf(f,
    -                            "listening_ip=%s/%s\n",
    -                            lanip, lanmask);
    +                            "listening_ip=%s\n",
    +                            lanifname);
                             int ports[4];
                             if ((ports[0] = nvram_get_int("upnp_min_port_ext")) > 0 &&
                                 (ports[1] = nvram_get_int("upnp_max_port_ext")) > 0 &&
    Also, the way the code was, I don't think this would add a line for each LAN when more than one is checked in the GUI. You may make another LAN ( br1 ) and check both of them in the GUI for miniupnpd and see if they both get put in the conf file.
     
    kille72 likes this.
  89. kille72

    kille72 LI Guru Member

    I'll try it tomorrow. Thanks!
     
  90. kille72

    kille72 LI Guru Member

    @Sean B. no luck:

    Code:
    [rc] CC services.o
    services.c: In function ‘start_upnp’:
    services.c:1173:9: error: ‘lanip’ undeclared (first use in this function)
    services.c:1173:9: note: each undeclared identifier is reported only once for each function it appears in
    services.c:1173:16: error: ‘lanmask’ undeclared (first use in this function)
    services.c: In function ‘stop_samba’:
    services.c:2277:2: warning: implicit declaration of function ‘enable_gro’
    services.c: At top level:
    services.c:2284:6: warning: conflicting types for ‘enable_gro’
    services.c:2277:2: note: previous implicit declaration of ‘enable_gro’ was here
    Makefile:212: recipe for target 'services.o' failed
    make[5]: *** [services.o] Error 1
    make[5]: Leaving directory '/home/kille72/tomato-arm-kille72/release/src-rt-6.x.4708/router/rc'
    Makefile:2870: recipe for target 'rc' failed
    make[4]: *** [rc] Error 2
    make[4]: Leaving directory '/home/kille72/tomato-arm-kille72/release/src-rt-6.x.4708/router'
    Makefile:123: recipe for target 'all' failed
    make[3]: *** [all] Error 2
    make[3]: Leaving directory '/home/kille72/tomato-arm-kille72/release/src-rt-6.x.4708'
    Makefile:978: recipe for target 'bin' failed
    make[2]: *** [bin] Error 2
    make[2]: Leaving directory '/home/kille72/tomato-arm-kille72/release/src-rt-6.x.4708'
    Makefile:997: recipe for target 'z' failed
    make[1]: *** [z] Error 2
    make[1]: Leaving directory '/home/kille72/tomato-arm-kille72/release/src-rt-6.x.4708'
    Makefile:1003: recipe for target 'ac68z' failed
    make: *** [ac68z] Error 2
    Edit: no problem in older miniupnpd: 2.0.20170421.
     

    Attached Files:

    Last edited: Feb 18, 2018
  91. Sean B.

    Sean B. LI Guru Member

    My bad, tis what I get for coding in a hurry. Didn't read down a couple lines to see lanip and lanmask were used in more places. Give this one a run:

    Code:
    diff --git a/release/src-rt-6.x.4708/router/rc/services.c b/release/src-rt-6.x.4708/router/rc/services.c
    index 40c1066..28be9ef 100644
    --- a/release/src-rt-6.x.4708/router/rc/services.c
    +++ b/release/src-rt-6.x.4708/router/rc/services.c
    @@ -1143,6 +1143,7 @@ void start_upnp(void)
     
                     char lanN_ipaddr[] = "lanXX_ipaddr";
                     char lanN_netmask[] = "lanXX_netmask";
    +                char lanN_ifname[] = "lanXX_ifname";
                     char upnp_lanN[] = "upnp_lanXX";
                     char br;
     
    @@ -1155,16 +1156,18 @@ void start_upnp(void)
     
                         sprintf(lanN_ipaddr, "lan%s_ipaddr", bridge);
                         sprintf(lanN_netmask, "lan%s_netmask", bridge);
    +                    sprintf(lanN_ifname, "lan%s_ifname", bridge);
                         sprintf(upnp_lanN, "upnp_lan%s", bridge);
     
                         char *lanip = nvram_safe_get(lanN_ipaddr);
                         char *lanmask = nvram_safe_get(lanN_netmask);
    +                    char *lanifname = nvram_safe_get(lanN_ifname);
                         char *lanlisten = nvram_safe_get(upnp_lanN);
     
    -                    if((strcmp(lanlisten,"1")==0) && (strcmp(lanip,"")!=0) && (strcmp(lanip,"0.0.0.0")!=0)) {
    +                    if((strcmp(lanlisten,"1")==0) && (strcmp(lanifname,"")!=0)) {
                             fprintf(f,
    -                            "listening_ip=%s/%s\n",
    -                            lanip, lanmask);
    +                            "listening_ip=%s\n",
    +                            lanifname);
                             int ports[4];
                             if ((ports[0] = nvram_get_int("upnp_min_port_ext")) > 0 &&
                                 (ports[1] = nvram_get_int("upnp_max_port_ext")) > 0 &&
     
    Techie007 and kille72 like this.
  92. kille72

    kille72 LI Guru Member

    No log flood. Bingo, thanks! I have updated upnpd to the newest version as well:
    https://bitbucket.org/kille72/tomato-arm-kille72/commits/c4ae03b98858ca079b580fb632c2caadbdd259de
    https://bitbucket.org/kille72/tomato-arm-kille72/commits/bfb985beafc0e362b01af549dbdfb37c9d515e8b

    /etc/upnp/config:
    Code:
    ext_ifname=vlan2
    port=0
    enable_upnp=yes
    enable_natpmp=no
    secure_mode=yes
    upnp_forward_chain=upnp
    upnp_nat_chain=upnp
    upnp_nat_postrouting_chain=pupnp
    notify_interval=60
    system_uptime=yes
    friendly_name=Asus Router
    model_name=Asus RT-AC56U
    model_url=http://linksysinfo.org/index.php?forums/tomato-firmware.33/
    manufacturer_name=Tomato Firmware
    manufacturer_url=http://linksysinfo.org/index.php?forums/tomato-firmware.33/
    
    clean_ruleset_interval=600
    clean_ruleset_threshold=20
    presentation_url=
    uuid=12406107-631b-4d5f-b6e6-06ebe546b678
    
    
    listening_ip=br0
    allow 1024-65535 192.168.1.1/255.255.255.0 1024-65535
    listening_ip=br1
    allow 1024-65535 192.168.2.1/255.255.255.0 1024-65535
    
    deny 0-65535 0.0.0.0/0 0-65535
    Logs:
    Code:
    Feb 18 13:27:57 Asus daemon.notice miniupnpd[5004]: version 2.0 started
    Feb 18 13:27:57 Asus daemon.notice miniupnpd[5004]: HTTP listening on port 46097
    Feb 18 13:32:49 Asus daemon.notice miniupnpd[5004]: shutting down MiniUPnPd
    upnpd.PNG
     
    edusodanos, Sean B. and txnative like this.
  93. txnative

    txnative Networkin' Nut Member

    Will this be added to the next beta the miniupnpd? Is there a WIP for tomato-arm wl driver? I had used your 2017.3 VPN-64K on the R6300v2 and I read some problems on the 2.4 and none on the 5 ghz, during my usage with that build i had encountered them as well along with upnp. Upnp was not opening ports for my playstation during the test connection utility on the playstation was telling me that upnp was unavailable, I could uncheck the settings in upnp save and apply and it work but i had some really laggy games and the 2.4 was giving me half bandwidth, however it was stable just half. I apologize if I'm asking a question that may have been asked in the above commits, have a wonderful day Peace.
     
    kille72 likes this.
  94. The Master

    The Master Network Guru Member

    So in the next Beta Multiwan is working again. NICE :)
     
  95. kille72

    kille72 LI Guru Member

    Last edited: Feb 18, 2018
  96. kille72

    kille72 LI Guru Member

    We have no good solution so far to the 2.4 GHz problem on some models (most works well). UPNP test version coming soon to some models.
     
    Last edited: Feb 18, 2018
  97. kille72

    kille72 LI Guru Member

    We'll consider this as well;)
     
    WildFireSG likes this.
  98. kille72

    kille72 LI Guru Member

    joew333 likes this.
  99. Sean B.

    Sean B. LI Guru Member

    @kille72 , did you check if miniupnpd gets enabled on all LAN's when more than one exists as I suggested? I'm curious if I didn't see a section of code, or if it will only enable on br0.
     
  100. kille72

    kille72 LI Guru Member

    Sean B. and AndreDVJ like this.
  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice