1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Found bug in status-devices.asp

Discussion in 'Tomato Firmware' started by fyellin, May 16, 2009.

  1. fyellin

    fyellin LI Guru Member

    I found what I believe are two bugs in this file. I'm hoping that someone with better knowledge than mine of Tomato and JavaScript can confirm these bugs. Also, how does this info get back to JonZ?

    Both bugs are in the loop that go through dhcpd_static at around line 284.

    #1) The loop calls find(a[0], ipp + a[1]). I'm pretty sure the "ipp +' is a mistake. It seems the second field of this table used to contain just the last octet, rather than the complete ip address, and ipp + a[1] was needed for the whole address. This is no longer the case.

    #2) The find(...) also fails in another way. If the MAC address listed in the table is '00:00:00:00:00:00', this is supposed to be a flag that says "this machine is listed so that this IP address will have a name. Yet the "find" will fail, rather than appropriately attaching the name.
     
  2. SgtPepperKSU

    SgtPepperKSU Network Guru Member

    I can confirm this. However, when I run firebug and correct the calls, I see double-entries in the list. Still a bug, but it seems to be covering up another bug :tongue:
    I wasn't aware of that use of 00:00:00:00:00:00 (looking through other code, it sure seems to be the case), but I can confirm that it doesn't take that into account.
    If I remember right, his email address is at the end of the FAQ on the Tomato site. You should drop him a line on this. Good catch.
     

Share This Page