1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Save button not working

Discussion in 'Tomato Firmware' started by WillDeed, Jul 14, 2013.

  1. WillDeed

    WillDeed Reformed Router Member

    Just flashed Tomato v1.28.0000 MIPSR2-110 K26 USB AIO on my E3200 from DD-WRT. Did a 30/30/30 before and after flash.

    Went to http://192.168.1.1/basic-network.asp and tried to make some changes, but the save button doesn't seem to do anything. No message, no reload, no nothing. Save button on other pages seem to work just fine.

    I did some research on here and tried "nvram commit" and saw no errors. Also tried reflashing Tomato with 30/30/30 before and after with no effect.

    Viewed the source of basic-network.asp and noticed the first line is this:
    Code:
    if (lg.isEditing()) return;
    This seemed like something that would cause the save button to look like it's not doing anything, so I tried to edit the source through the Telnet interface, but it's read only.

    Question #1: Anyone know what's going on with the save button on basic-network.asp?

    Question #2: Is there a way I can edit the source for the GUI pages, so I can try to troubleshoot myself?

    Thanks
     
  2. Elfew

    Elfew Addicted to LI Member

    try different browser and let us know :)
     
  3. Planiwa

    Planiwa LI Guru Member

    I can get that (non) response by disabling Javascript. :)

    Now, if the OP really, really wants to mess with the .asp sources, I am all for it.
    I have done this myself, and it is my view that if more people did this, the User interface might get fixed through "crowd-sourcing", since it appears that the developers have different priorities (or abilities).

    For example, every time a [SAVE] button is pushed, there should be a Syslog entry. This is so obvious, yet who has even thought about it, let alone done it?

    Of course one might wonder whether it is wise to let someone mess with their GUI pages, if they can't figure out how on their own.
    So long as it's their own router, why not?

    So: One could start by copying the /www content to /www/ext

    Then one could refer to pages as .../ext/foo instead of .../foo

    Then one could take care of the unexpected complications. ;-)


    Please share your findings and improvements. My dream is that creative users could prototype improvements and developers might then choose to benefit from the better improvements. :)
     
  4. WillDeed

    WillDeed Reformed Router Member

    I tried different browser (switched from chrome to IE), but that didn't help.

    I also tried your suggestion before posting Planiwa, but the filesystem is read-only, so I can't just make a subdirectory in /www. That would have been ideal.

    I guess I could have used a different web server with optware and copied all the files over and made changes accordingly.

    The only other option I know of (with my admittedly limited knowledge of how Tomato works) is to change the source, recompile and reflash, which sounds like a painful troubleshooting process.

    Anyway, it's working now, even though I don't know exactly why.

    I rebooted the router (which doesn't seem like it should have mattered since I already did 30/30/30s before/after two rounds of flashing), went directly to basic-networking.asp, and clicked save without making any config changes. That worked. I then changed the IP and disabled DHCP and saved. Then set wireless security settings and saved, which worked too (originally wasn't working).

    Originally when I had the problem, I believe the steps I took were to enable wireless and save, then do all of the above at once and try to save without a response.

    Hopefully this info is minorly helpful to someone.

    Thanks to all the devs for their hard work!
     
  5. Planiwa

    Planiwa LI Guru Member

    Try these commands and report your results: :)

    Code:
    touch /www/willdeed-should-read-carefully
    Code:
    touch /www/ext/planiwa-is-not-so-stupid
     
  6. Victek

    Victek Network Guru Member

    Do it simply.. enter in developer mode with your browser (F12 in Chrome for instance), find the bug (debug mode) and then we can see the issue source.
     
  7. WillDeed

    WillDeed Reformed Router Member

    My bad, Planiwa. I'm an idiot:

    Code:
    root@unknown:/tmp/var/wwwext# ls -lha
    drwxr-xr-x    3 root     root         100 Jul 14 21:53 .
    drwxr-xr-x   11 root     root         220 Jan  1  1970 ..
    drwxr-xr-x    2 root     root          80 Jul 14 09:12 cgi-bin
    -rw-r--r--    1 root     root           0 Jul 14 21:50 planiwa-is-not-so-stupid
    -rw-r--r--    1 root     root           0 Jul 14 21:53 willdeed-should-pay-attention-to-symlinks
    
    Victek: Great suggestion. I will do this next time I encounter a problem.

    thanks guys!
     
  8. Planiwa

    Planiwa LI Guru Member

    Well, if I had said nothing, you would have thought it's impossible.
    But now you know that it's possible, and perhaps you will explore your good idea of making custom versions.

    Elsewhere I showed 6 problems in the first part of the first web page. These problems have to do with usability and showing vital statistics such as memory and NVRAM space utilization. One developer seems not to care about these (old) problems, saying that they don't affect the functioning of the router.

    That seems like saying it doesn't matter that the odometer and the fuel gauge are broken, since it doesn't affect the running of the engine. When individual users such as yourself make a prototype page that does it right, it's an easy thing for developers to incorporate it, without having to worry that it can't be done, or that it's not important enough to bother.

    Please do it and share your results.
     
  9. Planiwa

    Planiwa LI Guru Member

    For example, the 6 problems I mentioned, I simply fixed them by making the necessary changes in

    /www/ext/status-overview.asp
    and
    /www/ext/status-data.jsx

    It was very easy.

    I'd like to show the images, but I don't know how to include images. :-(
     
  10. Planiwa

    Planiwa LI Guru Member

  11. Elfew

    Elfew Addicted to LI Member

    @Planiwa - could you provide git commits? It should help and your work would be included in other builds... Magic of open source
     

Share This Page