1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Separate Wireless from Connection Settings?

Discussion in 'Tomato Firmware' started by testymctest, Oct 7, 2008.

  1. testymctest

    testymctest Addicted to LI Member

    Hi,
    ive been using Tomato since Version 1.15 on my WRT54GL and im very happy with that.

    Today ive found an issue thats been bothering me:
    [​IMG]
    When you unexpectedly have to modifiy your Wireless Connection Settings, for example to grant a visitor with older hardware access, you modify the "Wireless" part and click "Save".

    Strangely, your Internet Connection gets reset!

    I assume, this is because Tomato does not check if your Internet Connection details remained the same and just reconnects.

    Maybe im wrong, but id like to hear some thoughts from you.
     
  2. fyellin

    fyellin LI Guru Member

    If it's really bothering you, you can ssh/telnet to the router and use the "wl" command to set up the wireless in any way you want, without affecting the internet connection. I doubt (but don't know for sure) whether anything set using "wl" is sticky and will survive a reboot.

    I'm sure your diagnosis of the "cause" is correct. I don't have the sources on this computer, though.

    For me, I'll stick to the simplicity of the GUI.
     
  3. testymctest

    testymctest Addicted to LI Member

    If my assumption is correct, it would be sufficient to move the "LAN" and the "Wireless" parts to another entry in the menu. (and away from "WAN/Internet")

    The next point, "Identification", is quite empty, maybe something could be merged.

    I'm just suggesting, this wouldn't affect Tomato's simplicity in any way.
     
  4. testymctest

    testymctest Addicted to LI Member

    Another way would be to separate the form into three smaller forms, each with its own save button.
     
  5. SgtPepperKSU

    SgtPepperKSU Network Guru Member

    Actually, the way the Tomato GUI is structured it is very possible to only have one save button, but have it only restart the services needed for the values that have actually changed. That is what I did on my VPN GUI when you edit one, both, or neither of the clients/servers, it only restarts the needed services.

    He just has it currently set up to restart "everything" when you submit that form. In fact, all that would need to change is
    Code:
    <input type='hidden' name='_service' value='*'>
    to
    Code:
    <input type='hidden' name='_service' value=''>
    and have a
    Code:
    if (focused)
    {
    	var fom = E('_fom');
    	var serviceString = fom._service.value;
    	switch (focused.name)
    	{
    	...
    	case '_wan_ipaddr':
    	case '_wan_proto':
    		if (serviceString.indexOf('<whatever>-restart') < 0)
    		{
    			if (serviceString != "") serviceString += ",";
    			serviceString += '<whatever>-restart';
    		}
    		break;
    	...
    	case '_wl_crypto':
    	case '_wl_ssid':
    		if (serviceString.indexOf('<whatever>-restart') < 0)
    		{
    			if (serviceString != "") serviceString += ",";
    			serviceString += '<whatever>-restart';
    		}
    		break;
    	}
    	fom._service.value = serviceString;
    }
    to the verifyFields function. The only tough part would be identifying what services need to be restarted based on what's changed.

    So, to answer your question, it is very doable. You just need to convince Jon it'd be worth the change.
     
  6. testymctest

    testymctest Addicted to LI Member

    Hey, thanks for your reply.

    Afaik one of Tomatos features is to restart only the neccessary processes when the user makes a change.

    The presence of the issue clearly violates this statement. Where can i contact this "Jon" ?
     
  7. SgtPepperKSU

    SgtPepperKSU Network Guru Member

    It could very well be that he consciously decided that those changes should result in all of the those services restarting, but you can find his email address on the Tomato FAQ.
     

Share This Page